[macOS] feat: Support Tabs in Quick Terminal #5370
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohsatoh
commented
Jan 25, 2025
| animateOut() | ||
| } | ||
|
|
||
| @IBAction func newTab(_ sender: Any?) { |
There was a problem hiding this comment.
📝
This is never called because the window is an NSPanel without a title bar. So, I removed it and added the observer for Ghostty.Notification.ghosttyNewTab.
| @@ -329,6 +329,9 @@ class TerminalManager { | |||
| guard let surfaceView = notification.object as? Ghostty.SurfaceView else { return } | |||
| guard let window = surfaceView.window else { return } | |||
|
|
|||
| // return if window is not in our managed windows | |||
| guard windows.contains(where: { $0.controller.window == window }) else { return } | |||
There was a problem hiding this comment.
📝
If the window is not managed by the TerminalManager (which is usually the case when it is managed by the QuickTerminalManager), the process will be aborted. Without this, a new TerminalWindow would be created.
…e left (like native tabs)
sohsatoh
force-pushed
the
feat/quickterm-with-tab
branch
from
be37844 to
98a0e07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #2329
This pull request implements a tab management feature for the Quick Terminal in the Ghostty for macOS.
macOS does not support tab management without a title bar. Therefore, this PR implements non-native tabs instead of using macOS native tabs.
Changes
Appearance
window-theme = dark
window-theme = light
Notes
The implementation is designed to work similarly to native tabs and to behave consistently with the (standard) terminal windows in Ghostty. However, there may be some aspects I might have overlooked. Please feel free to make any necessary fixes to the implementation as needed.