Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gtk): detect modifier keys without cursor movement #5367

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nnyyxxxx
Copy link

This fixes a regression where pressing Ctrl while hovering over a link wouldn't detect
the link until the cursor moved.

Tested on both x11 / wayland

Fixes #5191

Copy link
Contributor

@mitchellh mitchellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since your changes are both GTK-specific and not window protocol specific, I believe it'd make more sense to put them in apprt/gtk/key.zig. What do you think?

I haven't vetted the actual approach yet, just something I immediately noticed.

@nnyyxxxx
Copy link
Author

Since your changes are both GTK-specific and not window protocol specific, I believe it'd make more sense to put them in apprt/gtk/key.zig. What do you think?

yes, that makes sense. I'll start working on that

@nnyyxxxx nnyyxxxx requested a review from mitchellh January 25, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regression(gtk): Pressing Ctrl when mouse is over a hyperlink does not detect the link until cursor is moved
2 participants