Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk: implement audio bell #5326

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jcollie
Copy link
Collaborator

@jcollie jcollie commented Jan 23, 2025

Fixes #2710

Resurrecting a PR from before Ghostty went public.

@mitchellh
Copy link
Contributor

Just want to note I'm going to not review this pending further discussion (I know there's a discussion open). One thing I noticed right away though if you care is this uses the old @hasDecl method of surface callbacks and we should instead switch to the apprt actions system.

@jcollie jcollie force-pushed the gtk-bell-2 branch 3 times, most recently from b4c992a to 76a0193 Compare January 25, 2025 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants