apprt/gtk: ibus activation should not encode keys #5310
Merged
+24
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up our handling of when GTK tells us the input method handled the key press to address more scenarios we should not encode the key event. The comments in this diff should explain clearly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3567
This cleans up our handling of when GTK tells us the input method handled the key press to address more scenarios we should not encode the key event. The comments in this diff should explain clearly.
Reproduction is simple:
super+.to activate the emoji keyboard.is written to the shell AND the emoji keyboard is activated.The bug is that
.should not be encoded since it was used to activate the emoji keyboard. This PR fixes that.