Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default key bindings to capture full screen contents (write_screen_file) #5285

Conversation

MadLittleMods
Copy link
Collaborator

The current default keybinding on Ctrl-Shift-J/Cmd-Shift-J utilize write_scrollback_file which only captures text that's scrolled off-screen. This can be confusing, as I would expect it to capture everything on and off-screen.

Per the docs, write_screen_file is the "Same as write_scrollback_file but writes the full screen contents" which is perfect to solve this problem and aligns exactly with the expected behavior.

This change addresses the friction that people have reported in the discussions below and specifically coming from the search scrollback feature discussion, where Ctrl-Shift-J/Cmd-Shift-J is one of the interim decent workarounds but then you also have to figure out the extra intricacy to use write_screen_file instead of write_scrollback_file.

Previous discussions:

Workaround

Before this PR is merged, you can achieve the same result by updating your Ghostty config:

.config/ghostty

# So we have more scrollback history (the size of the scrollback buffer in bytes)
scrollback-limit = 100000000

# The default keybindings use `write_scrollback_file` but that only includes what is
# offscreen. `write_screen_file` includes what's on screen and offscreen.
keybind = ctrl+shift+j=write_screen_file:paste
keybind = ctrl+shift+alt+j=write_screen_file:open

@mitchellh mitchellh merged commit ddf7173 into ghostty-org:main Jan 22, 2025
30 checks passed
@mitchellh
Copy link
Contributor

Thanks, I think this is a very reasonable change.

@github-actions github-actions bot added this to the 1.1.0 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants