gtk(wayland): respect compositor SSD preferences #5124
Merged
+74
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compositors can actually tell us whether they want to use CSD or SSD!
mitchellh
reviewed
Jan 16, 2025
| @@ -57,6 +59,12 @@ pub const App = struct { | |||
| registry.setListener(*Context, registryListener, context); | |||
| if (display.roundtrip() != .SUCCESS) return error.RoundtripFailed; | |||
|
|
|||
| if (context.kde_decoration_manager != null) { | |||
| // FIXME: Roundtrip again because we have to wait for the decoration | |||
There was a problem hiding this comment.
This is fine for now. Ideally we can add the fd to the GTK event loop so the event loop wakes up when we have data to process.
|
Oops I forgot to fix macOS. Doing this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compositors can actually tell us whether they want to use CSD or SSD!
(Ignore the context menu changes — they will most likely be unified after #4952 anyway)