[macOS] Adopt @Observable in SwiftUI code #4511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves off of ObservableObject and @published over to @observable, which is preferred as it allows views to observe changes on a per-property basis rather than an entire object at a time. I went through the app and tried to compare behavior where I could, and I couldn't spot any visual differences, but I am sure there's good chance I have missed something. This also requires updating the minimum macOS deployment target to 14.0. If that is unacceptable, I am happy just closing this PR.
harlanhaskins
commented
Jan 3, 2025
| self.delegate?.cellSizeDidChange(to: size) | ||
| } | ||
| .onChange(of: viewModel.surfaceTree?.hashValue) { _ in | ||
| .onChange(of: viewModel.surfaceTree?.hashValue) { |
There was a problem hiding this comment.
Given that Container is now @Observable, this may no longer be required. A view will observe the properties of all @Observable instances it reads from during body, which means we no longer need to manually propagate changes up from child objects. I am not confident enough to remove this, however.
|
macOS 14 as a minimum deployment target is unacceptable. We want to continue supporting all supported Apple platforms. That’s the reason I was holding back. Sorry! But thanks for trying… |
|
No worries, this was still a fun way to get acquainted with the codebase. Thanks for the quick reply! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves off of
ObservableObjectand@Publishedover to@Observable, which is preferred as it allows views to observe changes on a per-property basis rather than an entire object at a time.I went through the app and tried to compare behavior where I could, and I couldn't spot any visual differences, but I am sure there's good chance I have missed something.
This also requires updating the minimum macOS deployment target to 14.0. If that is unacceptable, I am happy just closing this PR. Increasing the deployment target required updating some
onChangecallsites to avoid depreciation warnings.