Fix: Correct version strings for simdutf and cimgui to match vendored files #4468
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cimgui version listed does not match the upstream commit or the vendored cimgui files
Checking the upstream
git log
the commit corresponds tocommit e391fe2e66eb1c96b1624ae8444dc64c23146ef4 (tag: v1.90.6-docking)
however thebuild.zig.zon
is outdated.The vendored cimgui files also contain the header
I wasn't too clear with what the comment meant:
and assumed it was referring to the vendored cimgui files, added a comment pointing out where to find the cimgui source mentioned.