Correct typos and update typos.toml #4456
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the version of
typos
in nixpkgs is still at 1.28.4 (as of 2 weeks ago), while the latest version is 1.29.3. For tools like this where the dictionary is constantly being updated, we might want to consider usinguses: crate-ci/typos@master
directly in our CI workflow instead of the version from nixpkgs.I understand the current setup using
devShell.nix
helps maintain consistency between local development and CI environments. However, I found some typos that can be detected by the new version of typos, but were missed by the old version of typos on nixpkgs.Proposal:
crate-ci/typos
action in CI while keeping nixpkgs version for local development (catching more typos in CI but introducing some inconsistency)