Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typos and update typos.toml #4456

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

liby
Copy link
Contributor

@liby liby commented Jan 3, 2025

I noticed that the version of typos in nixpkgs is still at 1.28.4 (as of 2 weeks ago), while the latest version is 1.29.3. For tools like this where the dictionary is constantly being updated, we might want to consider using uses: crate-ci/typos@master directly in our CI workflow instead of the version from nixpkgs.

I understand the current setup using devShell.nix helps maintain consistency between local development and CI environments. However, I found some typos that can be detected by the new version of typos, but were missed by the old version of typos on nixpkgs.

image

Proposal:

  1. Use crate-ci/typos action in CI while keeping nixpkgs version for local development (catching more typos in CI but introducing some inconsistency)

@mitchellh
Copy link
Contributor

I understand the current setup using devShell.nix helps maintain consistency between local development and CI environments. However, I found some typos that can be detected by the new version of typos, but were missed by the old version of typos on nixpkgs.

The issue with that is I can't run typos locally (without installing software outside of Nix which is bleh). I'm happy to just stay on the old version. We can overlay Nixpkgs-unstable for typos which will get us at least the latest that Nix supports....

@mitchellh mitchellh enabled auto-merge January 3, 2025 03:15
@mitchellh mitchellh merged commit f2d255d into ghostty-org:main Jan 3, 2025
24 checks passed
@github-actions github-actions bot added this to the 1.0.2 milestone Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants