Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos: make auto-update optional #4436

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

jparise
Copy link
Collaborator

@jparise jparise commented Jan 2, 2025

When unset, we use Sparkle's default behavior, which is based on the user's preference stored in the standard user defaults.

The rest of the previous behavior is preserved:

  • When SUEnableAutomaticChecks is explicitly false, auto-updates are disabled.
  • When 'auto-update' is set, use its value to set Sparkle's auto-update behavior.

Fixes #4433

When unset, we use Sparkle's default behavior, which is based on the
user's preference stored in the standard user defaults.

The rest of the previous behavior is preserved:
- When SUEnableAutomaticChecks is explicitly false, auto-updates are
  disabled.
- When 'auto-update' is set, use its value to set Sparkle's auto-update
  behavior.
@mitchellh mitchellh merged commit 7eb6b29 into ghostty-org:main Jan 2, 2025
21 checks passed
@mitchellh
Copy link
Contributor

Perfect

@github-actions github-actions bot added this to the 1.0.2 milestone Jan 2, 2025
@jparise jparise deleted the macos-auto-update-default branch January 16, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change auto-update to optional, default to null
2 participants