core: detect what desktop environment the user is using

[jcollie]

No description provided.

[tristan957]

It's XDG_CURRENT_DESKTOP

[jcollie]

It's XDG_CURRENT_DESKTOP

XDG_CURRENT_DESKTOP is wierd, it can actually be a list of up to 3 desktop names. I have no idea why you would want that but that's what it's documented to be. XDG_SESSION_DESKTOP is just the current DE.

[rhodes-b]

this could also potentially be a good time / place to also print what OS someone is using

its typically found in /etc/*release on many distros not sure how much this covers

I know you talked about that before

[jcollie]

this could also potentially be a good time / place to also print what OS someone is using

its typically found in /etc/*release on many distros not sure how much this covers

I know you talked about that before

Yeah I've thought about that but /etc/os-release is not super easy to parse (I believe basically it's a list of shell environment variables). So I don't think that it's necessary to do that at this point. It's definitely out of scope for this PR.

[anund]

May want to grab XDG_SESSION_TYPE as additional information in the other case. Wandering around a few vms with default, perhaps incorrect, configuration XDG_SESSION_DESKTOP wasn't always set. (plasma,gnome,hyprland seem ok).

[jcollie]

May want to grab XDG_SESSION_TYPE as additional information in the other case. Wandering around a few vms with default, perhaps incorrect, configuration XDG_SESSION_DESKTOP wasn't always set. (plasma,gnome,hyprland seem ok).

We're mainly concerned with gnome/not gnome at this point. If we ever need to detect a specific DE other than Gnome we can refine this check. We can add XDG_SESSION_TYPE in the future if it's needed.

[mitchellh]

Can you please rebase, there are conflicts

[mitchellh]

Can you please rebase, there are conflicts

[jcollie]

Can you please rebase, there are conflicts

Done, and done.