Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add background-opacity needs restart #4140

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Conversation

ferrgo
Copy link
Contributor

@ferrgo ferrgo commented Dec 31, 2024

The section informing that some configs need a restart points that the specific config should have details about this. This adds the information that background-opacity on MacOS needs a restart

Some configuration options cannot be reloaded at runtime; others may only apply to newly created terminals. See the specific configuration option for details.

PS: lovin ghostty

src/config/Config.zig Outdated Show resolved Hide resolved
Co-authored-by: Aarni Koskela <akx@iki.fi>
@mitchellh mitchellh merged commit e7354e7 into ghostty-org:main Jan 2, 2025
@github-actions github-actions bot added this to the 1.0.2 milestone Jan 2, 2025
@ferrgo ferrgo deleted the patch-1 branch January 3, 2025 12:37
@gigamonster256
Copy link
Contributor

gigamonster256 commented Jan 3, 2025

@ferrgo @akx Are y'all sure changing background-opacity needs a restart to work? I doesn't for me, hot-reloads work just fine. Is there a specific state you need to be in where the config reload does not work?

@ferrgo
Copy link
Contributor Author

ferrgo commented Jan 21, 2025

@ferrgo @akx Are y'all sure changing background-opacity needs a restart to work? I doesn't for me, hot-reloads work just fine. Is there a specific state you need to be in where the config reload does not work?

For me opening Ghostty without this setting and trying to enable would require a restart. If background-opacity is set and I try to change it's value then the reload is enough. Is this ur scenario? Try deleting the option on config file, restarting Ghostty and trying to set it again.

PS.: Sorry for ghosttying u, have been off for a few days.

@gigamonster256
Copy link
Contributor

PS.: Sorry for ghosttying u, have been off for a few days.

Haha no worries. You were right about weirdness happening if a window was created with an opacity of 1 and then adjusted but it looks like it doesn't matter anymore: #5083

@ferrgo
Copy link
Contributor Author

ferrgo commented Jan 21, 2025

I see, indeed I had an issue that going fullscreen and back would not set opacity correctly, don't usually go fullscreen but testing now and its fixed indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants