gtk: don't use gtk_window_set_titlebar if adwaita is enabled but it's older than 1.4.0 #4110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristan957
approved these changes
Dec 30, 2024
|
It would be good to mention the discussion too. |
Yeah, once I get confirmation from the folks in #4097 that this actually works for them I'll update the description with relevant info. |
|
Failing CI is a flappy test. The rest looks good. Just advise when you want me to merge. |
jcollie
force-pushed
the
fix-4097
branch
3 times, most recently
from
4c0bc0b to
0c028e0
Compare
… older than 1.4.0
|
OK, I've gotten two reports that this fixes the issue so it's ready to merge. |
mitchellh
added a commit
that referenced
this pull request
Dec 31, 2024
Fix a regression from #4110 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4097