Improve invalid keybind error messages #3727
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherJL0
force-pushed
the
detailed-keybind-errors
branch
from
2f29653 to
670ee41
Compare
`desktop` is the default value of `gtk-single-instance`; `detect` is not a valid value.
I think this must have snuck in due to my fork falling behind the upstream.
…onfirmation Fixes ghostty-org#3648 The confirm-close-surface configuration can now be set to always ensuring a confirmation dialog is shown before closing a surface, even if shell integration indicates no running processes.
Co-authored-by: Gareth Widlansky <101901964+gerblesh@users.noreply.github.com>
This gives people finer-grained control over the coloring of their window titlebars. Currently only implemented for GTK. Signed-off-by: Tristan Partin <tristan@partin.io>
It currently has two backticks side by side, which end up rendering as actual backticks rather than a code-formatted blank space.
When writing selected text to file, use `topLeft` and `bottomRight` instead of `start` and `end` to ensure correct coordinate ordering. This fixes an issue where selection files could be empty when selecting text in reverse order. - Use `terminal.Selection.topLeft()` for start coordinate - Use `terminal.Selection.bottomRight()` for end coordinate
Quick Terminal now focuses on the surface under the mouse pointer when `focus-follows-mouse` is enabled. Fixes ghostty-org#3337
The original version had issues converting properly and caused broken glyphs. This version tries to be as simple as possible in order to make it easy to understand. I haven't measured the performance but in practice this will only happen during the first render of the glyph after a face change (i.e. during launch or when changing font size).
This allows for crisp bitmap font rendering once again.
Now we can be certain that bitmap fonts stay crisp. :^)
This is an expected occurrence with bitmap glyphs and causes unnecessary spam when using the terminal with one.
This reverts commit 322f166.
macOS bitmap-only fonts are a poorly documented format, which are often distributed as `.dfont` or `.dfon` files. They use a 'bhed' table in place of the usual 'head', but the table format is byte-identical, so enabling the use of bitmap-only fonts only requires us to properly fetch this table while calculating metrics. ref: https://fontforge.org/docs/techref/bitmaponlysfnt.html
A regression from adcaff7
… older than 1.4.0
Fixes ghostty-org#3219 We were holding a reference cycle to the base terminal controller. This was preventing the window from ever being fully deallocated.
Fixes ghostty-org#4146 This makes it so that keys such as `cmd+1` and `cmd+one` are identical.
otherJL0
force-pushed
the
detailed-keybind-errors
branch
from
670ee41 to
2daeb0d
Compare
|
The history here is a bit crazy and impossible to read. Can you try reopening a clean PR? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for Better keybind error messages discussion