Rename goto_split top/bottom directions to up/down.

[dpatterbee]

Renames the top/bottom directions of goto_split to up/down. I have tested this on linux (nixos) but given that goto_split is broken on linux anyway (#2866) there's not a whole lot to test.

I have no way to build on macOS so I can't verify that I've changed everything correctly for that.

Closes #3237

[mitchellh]

Thanks this looks good but I'm a bit worried now that we're released about backwards compatibility. Let me think about that.

[dpatterbee]

Here's a small patch which would retain "top" and "bottom" as aliases of the new "up" and "down" directions if that's the direction you'd like to go. I agree that breaking backwards compatibility 2 days post-launch is probably not ideal.

diff --git a/src/Surface.zig b/src/Surface.zig
index 1442af86..b4e9e593 100644
--- a/src/Surface.zig
+++ b/src/Surface.zig
@@ -4046,6 +4046,8 @@ pub fn performBindingAction(self: *Surface, action: input.Binding.Action) !bool
             .{ .surface = self },
             .goto_split,
             switch (direction) {
+                .top => apprt.action.GotoSplit.up,
+                .bottom => apprt.action.GotoSplit.down,
                 inline else => |tag| @field(
                     apprt.action.GotoSplit,
                     @tagName(tag),
diff --git a/src/input/Binding.zig b/src/input/Binding.zig
index f8cc71d0..1c318852 100644
--- a/src/input/Binding.zig
+++ b/src/input/Binding.zig
@@ -473,6 +473,11 @@ pub const Action = union(enum) {
         left,
         down,
         right,
+
+        // For backwards compatilbility purposes we also support "top" and "bottom" as aliases for
+        // "up" and "down"
+        top,
+        bottom,
     };
 
     pub const SplitResizeDirection = enum {

[mitchellh]

Thanks. It might be easier to actually implement a custom parseCLI function for this enum and translate the old values to the new values. That would clean up everything else. If you do this I will merge.

Please add tests for that as well.

Thank you!

[mitchellh]

Fantastic. Thank you!

[gigamonster256]

Documentation for goto_split was just added in #4388 which is out of date as of this being merged (assuming new names should be in the documentation instead of legacy top/bottom)