Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle intermediate bytes in CSI and ESC sequences #3132

Closed

Conversation

aymanbagabas
Copy link
Member

This adds missing handling for CSI and ESC commands.

Fixes: #3122

@mitchellh
Copy link
Contributor

Thanks, there are existing test (compilation) failures and we need to add test coverage for all of these. I'll probably push this into 1.0.1 anyways so no rush on this.

@apatterndarkly
Copy link
Contributor

Real nice!

As someone who exits insert mode with ctrl+[ on several apps in the terminal, I'd been spewing ;5u all over the place for the past few hours. Fortunately that little clue led me to a work around, but yeah I'm super happy to see this fix on its way, so thank you @aymanbagabas.

For the slim chance anyone lands here with my same issue in the meantime, my workaround was to add the following to my config:

keybind = ctrl+left_bracket=text:\x1b

✌️

This adds missing handling for CSI and ESC commands.

Fixes: #3122
@aymanbagabas
Copy link
Member Author

I accidentally closed the PR after force pushing the updated changes. Apparently, GitHub doesn't carry forked repository visibility settings :/

Could someone reopen the PR? Otherwise, I can create a new one

CC/ @mitchellh

mitchellh added a commit that referenced this pull request Jan 2, 2025
This adds missing handling for CSI and ESC commands.

Fixes: #3122

Supersedes: #3132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proper escape sequence intermediate handling
3 participants