terminal: PageList.reset has to zero arena memory to avoid reuse #2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2877 As the comment in the diff states, we rely on `mmap` to zero our memory. When we reset we are reusing previously allocated memory so we won't hit an `mmap`. We need to zero the memory ourselves. This is pretty slow if there is a lot of memory but in every case except allocation failures, we expect there to be only a few pages allocated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2877
As the comment in the diff states, we rely on
mmapto zero our memory. When we reset we are reusing previously allocated memory so we won't hit anmmap. We need to zero the memory ourselves.This is pretty slow if there is a lot of memory but in every case except allocation failures, we expect there to be only a few pages allocated.