-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alt keybindings for ctrl+ins = Copy and shift+ins = Paste #2870
Add alt keybindings for ctrl+ins = Copy and shift+ins = Paste #2870
Conversation
I hereby grant ghostty the right to use the code in this PR under the MIT license, in case you choose to merge it. 😄 |
The sibling PR to this was merged into Konsole today. Happy New Year 🥂 |
This PR has somehow broken toasts when copying with ctrl+shift+c. Toasts still display if I use the ctrl+ins bind. Reverting this commit does fix the issue, but I cannot for the life of me see how. |
Another datapoint: adding Adding any other keybind which does the |
Oh I see the issue. We only set a single accelerator for |
Is there a function preferable to set.put that would be better or is this a data structure thing? (Apologies if this a dumb question) |
The real bug is we should probably trigger the toast for any of the bindings. We should also probably put this binding before so that for menus we use the more traditional one |
On non-MacOS desktop environments (Windows, Gnome, KDE, Xfce, VS Code, ...),
ctrl+ins
andshift+ins
are system-wide alternate keybindings (except for terminals) forCopy
andPaste
respectively. This PR explicitly defines them as such in Ghostty's default keybindings.Using
ctrl+ins
as an alt-keybinding forCopy
allows static/context-unaware remapping ofCopy
tocmd+c
for Linux systems using Mac keyboards via keyd; with the defaultctrl+shift+c
keybinding for copy this is basically impossible (because that binding only applies to terminals).