GTK: Fix clicking on desktop notifications #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellh
reviewed
Aug 29, 2024
jcollie
force-pushed
the
gtk-desktop-notification-fix
branch
from
8ee2565 to
60f86e3
Compare
|
Rebased on current main and fixed to work with the Adwaita tabs. |
mitchellh
reviewed
Sep 13, 2024
mitchellh
reviewed
Sep 13, 2024
Currently, clicking on a desktop notification will bring Ghostty to the foreground, but it won't necessarily bring the right window to the top and it won't switch tabs or change the focus on splits. With this patch, clicking on a desktop notification will raise the correct window, change to the correct tab, and focus on the correct split that send the original desktop notification.
mitchellh
force-pushed
the
gtk-desktop-notification-fix
branch
from
60f86e3 to
9e73d86
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, clicking on a desktop notification will bring Ghostty to the foreground, but it won't necessarily bring the right window to the top and it won't switch tabs or change the focus on splits.
With this patch, clicking on a desktop notification will raise the correct window, change to the correct tab, and focus on the correct split that send the original desktop notification.