Inspector: change color picker to use hex values #2159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inspector currently show colors as decimal r,g,b values. With this change, the hex format is used instead. The motivation for this is that references to color typically use the hex format. One example is the palette definitions in a color scheme. Using the inspector/cell picker to help create and debug color themes should be more convenient after this change. If there's a usecase for the decimal format, we could add a config option or maybe a switch in the inspector UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hereby proposing a minor change to the inspector's color format as a PR.
The inspector currently show colors as decimal r,g,b values. With this change, the hex format is used instead.
The motivation for this is that references to color typically use the hex format. One example is the palette definitions in a color scheme. Using the inspector/cell picker to help create and debug color themes should be more convenient after this change.
If there's a usecase for the decimal format, we could add a config option or maybe a switch in the inspector UI.
After the change: