Font Improvements #2143
Merged
Font Improvements #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2141
Improves #2140
Multiple fixes or improvements:
If a style isn't found for a defined font family, we fallback to the regular face instead of looking for a fallback family that supports the style. This is less jarring. (do not fallback to a different font family for a style if the style isn't supported #2141)
If bold italic isn't supported, we fallback to italic first if it's available. If italic isn't available, we fallback to the regular font style.
If a font variation setting is set (
font-variation-*) and the defined font style is not found, then we retry searching for the font family without the style bits set. This addresses fonts that don't set that they support certain styles. (Berkeley Mono Variable not automatically finding bold variant #2140)Non-regular font variations are now respected. This was a typo where we were only applying the regular font variation (
font-variation) and ignoring styled variations (font-variation-bold). No reported bug for this.