Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos: jump to last_tab #2120

Merged
merged 6 commits into from
Aug 27, 2024
Merged

macos: jump to last_tab #2120

merged 6 commits into from
Aug 27, 2024

Conversation

edmz
Copy link
Collaborator

@edmz edmz commented Aug 19, 2024

(Somehow, I can't make super+0 trigger the action. Other bindings do work).

(No changes were made to GTK.)

Copy link
Contributor

@mitchellh mitchellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Noting some changes. I can get around to them if you don't.

src/config/Config.zig Outdated Show resolved Hide resolved
src/apprt/embedded.zig Outdated Show resolved Hide resolved
@edmz
Copy link
Collaborator Author

edmz commented Aug 26, 2024

Thanks for your feedback. I can definitely work on this since, tbh, it has been a fun challenge and I want to keep trying. I just didn't know if there was an interest.

@mitchellh
Copy link
Contributor

Thanks for this! I did some refactoring since my feedback was actually a bit difficult, and I made it work for GTK. This looks great. Thank you!

@mitchellh mitchellh merged commit 8032740 into ghostty-org:main Aug 27, 2024
17 of 19 checks passed
@mitchellh mitchellh deleted the last_tab branch August 27, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants