Add Config Option to Limit Number of Processes #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To protect your system and ghostty from misbehaving programs that launch too many processes for the system to handle (e.g. like a fork bomb), this implements an option to limit the number of processes that can be started in a surface. A fork bomb for example or other misbehaving program would then only take down one surface and not the entire system. Side node: If I am right in issue #2084, this feature does not actually work on a per surface basis but on all surfaces. If this is the case, it could probably be fixed together. Chances are, that I am wrong though 😉 Further improvements that could be done: - unify way to set cgroup attributes - set sane default: 10% of system max?
|
Looks great. I think unifying the cgroup attributes is a good idea... I can look into that since it's a bit more subjective. I think the default of not setting it at all for now is fine but some sane default in the future also makes sense. If we want to be really safe we can set it to something like 75% of max... |
|
Looks like querying the pids max while respecting potentially Ghostty itself being in a cgroup is a non-trivial (or at least, non performance trivial) task. For now let's keep it unset as a default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To protect your system and ghostty from misbehaving programs that launch too many processes for the system to handle (e.g. like a fork bomb), this implements an option to limit the number of processes that can be started in a surface.
A fork bomb for example or other misbehaving program would then only take down one surface and not the entire system.
Side node:
If I am right in issue #2084, this feature does not actually work on a per surface basis but on all surfaces. If this is the case, it could probably be fixed together. Chances are, that I am wrong though 😉
Further improvements that could be done: