Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos: implement resize overlay #2077

Merged
merged 5 commits into from
Aug 11, 2024
Merged

macos: implement resize overlay #2077

merged 5 commits into from
Aug 11, 2024

Conversation

mitchellh
Copy link
Contributor

Implements the resize overlay configurations completely, based on #2071.

CleanShot.2024-08-10.at.20.18.50.mp4

@mitchellh mitchellh merged commit 1cbeb26 into main Aug 11, 2024
36 checks passed
@mitchellh mitchellh deleted the resize-mac branch August 11, 2024 04:23
@clason
Copy link
Collaborator

clason commented Aug 11, 2024

I think there's a small bug: resize-overlay = after-first doesn't work for me, it always shows the overlay when opening a new tab. (Neither the default nor explicitly setting the option works; resize-overlay = never works as expected, though.)

(And wouldn't it be better to check for after-first and lastSize before creating the overlay?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants