terminal/kitty: shared memory size may be larger than expected for pages #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shared memory segment size must be a multiple of page size. This means that it may be larger than our expected image size. In this case, we trim the padding at the end.
jcollie
reviewed
Aug 10, 2024
| log.warn("unable to fstat shared memory {s}: {}", .{ path, err }); | ||
| return error.InvalidData; | ||
| // The size from stat on may be larger than our expected size because | ||
| // shared memory has to be a multiple of the page size. |
There was a problem hiding this comment.
One nit, this appears to be a macOS only problem. Linux fstat returns the correct size without padding to the next page size. Doesn't really affect the code, though. It'll work in both.
There was a problem hiding this comment.
Yeah that's why I said may. I don't fully understand the full scope of it and I'm not sure if this is client specific...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shared memory segment size must be a multiple of page size. This means that it may be larger than our expected image size. In this case, we trim the padding at the end.