kitty graphics: add support for shared memory transfer medium #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for using shared memory to transfer images between the CLI and Ghostty using the Kitty image protocol. This should be the fastest way to transfer images if the CLI program and Ghostty are running on the same system. Works for single image transfer using `kitten icat`: ``` kitten icat --transfer-mode=memory images/icons/icon_256x256.png ``` However trying to play a movie with `mpv` fails in Ghostty (although it works in Kitty): ``` mpv --vo=kitty --vo-kitty-use-shm=yes --profile=sw-fast --really-quiet video.mp4 ``` `mpv` appears to be sending frames using the normal image transfer commands but always setting `more_chunks` to `true` which results in an image never being shown by Ghostty. Shared memory transfer on Windows remains to be implemented.
|
Great work, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for using shared memory to transfer images between the CLI and Ghostty using the Kitty image protocol. This should be the fastest way to transfer images if the CLI program and Ghostty are running on the same system.
Works for single image transfer using
kitten icat:However trying to play a movie with
mpvfails in Ghostty (although it works in Kitty):mpvappears to be sending frames using the normal image transfer commands but always settingmore_chunkstotruewhich results in an image never being shown by Ghostty.Shared memory transfer on Windows remains to be implemented.