-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli/list-keybinds: add pretty printing #2052
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pretty printing to the +list-keybinds command. This is done by bringing in a dependency on libvaxis to handle the styling. Pretty printing happens automatically when printing to a tty, and can be disabled either by redirecting output or using the flag `--plain`
This is fully functional, but the alignment could use some work I think - we need some consensus on how these should be aligned for best viewing experience. |
These oses don't supply a tty layer, which prevents us from using the libvaxis tty. Eventually we can add in using stdout as a writer. For now, we just don't pretty print there.
Deinit the tty and vaxis to restore the terminal upon exiting the command
Doh! Forgot to deinit. Should be fixed now |
When on windows, set some default terminal size. The actual size is not very important to our use case here, but we do need one
That looks much better! Can you push a commit to this PR? |
I can't access your fork so probably not. Here's the patch however:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pretty printing to the +list-keybinds command. This is done by
bringing in a dependency on libvaxis to handle the styling. Pretty
printing happens automatically when printing to a tty, and can be
disabled either by redirecting output or using the flag
--plain
Fixes #2048