Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On 69dcea51, closing a terminal (cmd+d, exit, etc) closes all windows #5359

Closed
mitchellh opened this issue Jan 24, 2025 · 2 comments · Fixed by #5360
Closed

On 69dcea51, closing a terminal (cmd+d, exit, etc) closes all windows #5359

mitchellh opened this issue Jan 24, 2025 · 2 comments · Fixed by #5360
Assignees
Labels
Milestone

Comments

@mitchellh
Copy link
Contributor

Discussed in #5356

Originally posted by ahmedre January 24, 2025
On 69dcea5, if I close a terminal window using cmd+d or typing exit on macOS, it closes all open windows. I didn't change any configurations or anything, just updated to the latest. Restarting is always starting me with 2 windows, even if I had made more.

@mitchellh
Copy link
Contributor Author

I'm working on this now.

@mitchellh mitchellh self-assigned this Jan 24, 2025
@mitchellh
Copy link
Contributor Author

This only happens with the Swift apprt. Glfw isn't reproducing.

mitchellh added a commit that referenced this issue Jan 24, 2025
Fixes #5359

The comments explain what's going on. Longer term we should adjust our
termio/exec to avoid the SIGPIPE but its still possible (i.e. that
thread crashes) to happen so we should be robust to it.
mitchellh added a commit that referenced this issue Jan 24, 2025
Fixes #5359

The comments explain what's going on. Longer term we should adjust our
termio/exec to avoid the SIGPIPE but its still possible (i.e. that
thread crashes) to happen so we should be robust to it.
@github-actions github-actions bot added this to the 1.1.0 milestone Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant