Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ghostty.termcap and ghostty.terminfo from install #5253

Closed
mitchellh opened this issue Jan 20, 2025 · 2 comments · Fixed by #5311 or #5340
Closed

Remove ghostty.termcap and ghostty.terminfo from install #5253

mitchellh opened this issue Jan 20, 2025 · 2 comments · Fixed by #5311 or #5340
Labels
packaging
Milestone
1.1.0

Comments

@mitchellh
Copy link
Contributor

Discussed in #5229

Originally posted by titaniumtraveler January 19, 2025
When compiling ghostty with zig build it generates the files share/terminfo/ghostty.termcap and share/terminfo/ghostty.terminfo, which are not useful for the purpose of resolving terminal capabilities on linux.

Would it be a good idea to have an option to exclude them from the package? Or at least document for packagers what their purpose is and that they can be excluded?
jcollie added a commit to jcollie/ghostty that referenced this issue Jan 23, 2025
@jcollie
build: options to enable/disable terminfo & termcap install
45b81dc 
Fixes ghostty-org#5253

Add `-Demit-terminfo` and `-Demit-termcap` build options to
enable/disable installtion of source terminfo and termcap files.
jcollie added a commit to jcollie/ghostty that referenced this issue Jan 23, 2025
@jcollie
build: options to enable/disable terminfo & termcap install
6cf0a51 
Fixes ghostty-org#5253

Add `-Demit-terminfo` and `-Demit-termcap` build options to
enable/disable installtion of source terminfo and termcap files.
@jcollie jcollie mentioned this issue Jan 23, 2025
Merged
jcollie added a commit to jcollie/ghostty that referenced this issue Jan 23, 2025
@jcollie
build: options to enable/disable terminfo & termcap install
11dcaac 
Fixes ghostty-org#5253

Add `-Demit-terminfo` and `-Demit-termcap` build options to
enable/disable installtion of source terminfo and termcap files.
jcollie added a commit to jcollie/ghostty that referenced this issue Jan 23, 2025
@jcollie
build: options to enable/disable terminfo & termcap install
8f49a22 
Fixes ghostty-org#5253

Add `-Demit-terminfo` and `-Demit-termcap` build options to
enable/disable installtion of source terminfo and termcap files.
jcollie added a commit to jcollie/ghostty that referenced this issue Jan 23, 2025
@jcollie
build: options to enable/disable terminfo & termcap install
f20eea9 
Fixes ghostty-org#5253

Add `-Demit-terminfo` and `-Demit-termcap` build options to
enable/disable installtion of source terminfo and termcap files.
jcollie added a commit to jcollie/ghostty that referenced this issue Jan 23, 2025
@jcollie
build: options to enable/disable terminfo & termcap install
48a2c73 
Fixes ghostty-org#5253

Add `-Demit-terminfo` and `-Demit-termcap` build options to
enable/disable installtion of source terminfo and termcap files.
jcollie added a commit to jcollie/ghostty that referenced this issue Jan 23, 2025
@jcollie
build: options to enable/disable terminfo & termcap install
a60f3e4 
Fixes ghostty-org#5253

Add `-Demit-terminfo` and `-Demit-termcap` build options to
enable/disable installtion of source terminfo and termcap files.
jcollie added a commit to jcollie/ghostty that referenced this issue Jan 23, 2025
@jcollie
build: options to enable/disable terminfo & termcap install
4210ef7 
Fixes ghostty-org#5253

Add `-Demit-terminfo` and `-Demit-termcap` build options to
enable/disable installtion of source terminfo and termcap files.
mitchellh added a commit that referenced this issue Jan 24, 2025
@mitchellh
build: options to enable/disable terminfo & termcap install (#5311)
4c27743 
Fixes #5253

Add `-Demit-terminfo` and `-Demit-termcap` build options to
enable/disable installtion of source terminfo and termcap files.
@github-actions github-actions bot added this to the 1.1.0 milestone Jan 24, 2025
@mitchellh
Copy link
Contributor Author

Reverted c0eb698 to address follow up issues.

@mitchellh mitchellh reopened this Jan 24, 2025
jcollie added a commit to jcollie/ghostty that referenced this issue Jan 24, 2025
@jcollie
build: options to enable/disable terminfo & termcap install (take 2)
653d600 
Fixes ghostty-org#5253

Add -Demit-terminfo and -Demit-termcap build options to enable/disable
installtion of source terminfo and termcap files.
@jcollie jcollie mentioned this issue Jan 24, 2025
Merged
jcollie added a commit to jcollie/ghostty that referenced this issue Jan 24, 2025
@jcollie
build: options to enable/disable terminfo & termcap install (take 2)
2c40190 
Fixes ghostty-org#5253

Add -Demit-terminfo and -Demit-termcap build options to enable/disable
installation of source terminfo and termcap files.
mitchellh added a commit that referenced this issue Jan 24, 2025
@mitchellh
build: options to enable/disable terminfo & termcap install (take 2) (#…
47ff4c9 
…5340)

Fixes #5253

Add -Demit-terminfo and -Demit-termcap build options to enable/disable
installation of source terminfo and termcap files.

Replacement for #5311
@titaniumtraveler
Copy link

Thank you very much ❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
packaging
Projects
None yet
Milestone
1.1.0
2 participants
@mitchellh @titaniumtraveler