Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GTK: Menu should be in context menu if no titlebar #4732

Closed
mitchellh opened this issue Jan 7, 2025 · 4 comments
Closed

GTK: Menu should be in context menu if no titlebar #4732

mitchellh opened this issue Jan 7, 2025 · 4 comments
Labels
gui GUI or app issue regardless of platform (i.e. Swift, GTK) os/linux

Comments

@mitchellh
Copy link
Contributor

For our GTK build, we should put the menu into the context menu (as a Menu => submenu) if the titlebar is disabled. This will allow users to access the menu even when the titlebar is disabled or SSD is used.
@mitchellh mitchellh added gui GUI or app issue regardless of platform (i.e. Swift, GTK) os/linux labels Jan 7, 2025
@tristan957
Copy link
Collaborator

We could use https://docs.gtk.org/gtk4/class.PopoverMenuBar.html.

@tristan957
Copy link
Collaborator

We could also use a GtkBox styled with .toolbar.

@tristan957
Copy link
Collaborator

I guess you would also wrap it in an AdwToolbarView like what we currently have.

@ariasmn ariasmn mentioned this issue Jan 9, 2025
Merged
mitchellh added a commit that referenced this issue Jan 9, 2025
@mitchellh
feat(GTK): show menu in context menu if titlebar is disabled (#4864)
12ce9f2 
This PR addresses #4732.

While @tristan957 suggested alternative approaches, this implementation
provides a straightforward way to make the menu accessible when the
window decoration is disabled. It follows patterns seen in other GTK
apps for handling submenus, though not strictly in the context menu
format truth be told.

If there’s a better way to approach this or further refinements needed,
I’m happy to discuss and iterate. This has been a minor issue I’ve
encountered personally, and I’d like to help improve the experience for
others as well.

Small video of how it looks:


https://github.com/user-attachments/assets/59548fef-f11c-421f-b05b-be81eab6ce06
@mitchellh
Copy link
Contributor Author

Fixed by #4864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gui GUI or app issue regardless of platform (i.e. Swift, GTK) os/linux
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mitchellh @tristan957