-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macos-titlebar-style = hidden
with macos-non-native-fullscreen = true
shows titlebar on-top of the terminal
#3535
Comments
mitchellh
added
os/macos
gui
GUI or app issue regardless of platform (i.e. Swift, GTK)
labels
Dec 27, 2024
cristeahub
added a commit
to cristeahub/ghostty-terminal
that referenced
this issue
Dec 27, 2024
This fixes ghostty-org#3535 . There exists an issue in ghostty on mac where if you have hidden your titlebar, then enter fullscreen, the titlebar will reappear after exiting fullscreen. The reason for this is that after exiting fullscreen macos reapplies some styling on the new window created after exiting fullscreen. To combat this we will reapply the styling to hide the titlebar after exiting fullscreen. Steps to reproduce: - Open Ghostty - Enter fullscreen (non-native) - Exit fullscreen On main you will see the titlebar reappearing after exiting fullscreen, while that does not happen with this patch.
cristeahub
added a commit
to cristeahub/ghostty-terminal
that referenced
this issue
Dec 27, 2024
This fixes ghostty-org#3535 . There exists an issue in ghostty on mac where if you have hidden your titlebar, then enter fullscreen, the titlebar will reappear after exiting fullscreen. The reason for this is that after exiting fullscreen macos reapplies some styling on the new window created after exiting fullscreen. To combat this we will reapply the styling to hide the titlebar after exiting fullscreen. Steps to reproduce: - Open Ghostty - Enter fullscreen (non-native) - Exit fullscreen On main you will see the titlebar reappearing after exiting fullscreen, while that does not happen with this patch.
cristeahub
added a commit
to cristeahub/ghostty-terminal
that referenced
this issue
Dec 27, 2024
This fixes ghostty-org#3535 . There exists an issue in ghostty on mac where if you have hidden your titlebar, then enter fullscreen, the titlebar will reappear after exiting fullscreen. The reason for this is that after exiting fullscreen macos reapplies some styling on the new window created after exiting fullscreen. To combat this we will reapply the styling to hide the titlebar after exiting fullscreen. Required config: ``` macos-titlebar-style = hidden macos-non-native-fullscreen = true ``` Steps to reproduce: - Open Ghostty - Enter fullscreen (non-native) - Exit fullscreen On main you will see the titlebar reappearing after exiting fullscreen, while that does not happen with this patch.
mitchellh
pushed a commit
to cristeahub/ghostty-terminal
that referenced
this issue
Jan 2, 2025
This fixes ghostty-org#3535 . There exists an issue in ghostty on mac where if you have hidden your titlebar, then enter fullscreen, the titlebar will reappear after exiting fullscreen. The reason for this is that after exiting fullscreen macos reapplies some styling on the new window created after exiting fullscreen. To combat this we will reapply the styling to hide the titlebar after exiting fullscreen. Required config: ``` macos-titlebar-style = hidden macos-non-native-fullscreen = true ``` Steps to reproduce: - Open Ghostty - Enter fullscreen (non-native) - Exit fullscreen On main you will see the titlebar reappearing after exiting fullscreen, while that does not happen with this patch.
mitchellh
added a commit
that referenced
this issue
Jan 2, 2025
This fixes #3535 . There exists an issue in ghostty on mac where if you have hidden your titlebar, then enter fullscreen, the titlebar will reappear after exiting fullscreen. The reason for this is that after exiting fullscreen macos reapplies some styling on the new window created after exiting fullscreen. To combat this we will reapply the styling to hide the titlebar after exiting fullscreen. Required config: ``` macos-titlebar-style = hidden macos-non-native-fullscreen = true ``` Steps to reproduce: - Open Ghostty - Enter fullscreen (non-native) - Exit fullscreen On main you will see the titlebar reappearing after exiting fullscreen, while that does not happen with this patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Config
MacOS Version: 15.2
Steps to reproduce
Expected behavior:
Titlebar controls and title are still hidden
Actual behavior
The titlebar controls and title are visible on-top of the actual terminal view:
The text was updated successfully, but these errors were encountered: