Bug: reportPwd Url is not encoded #5289
Unanswered
achwo
asked this question in
Ideas and Issue Triage
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
When changing the pwd, the url is not correctly encoded in the shell integrations (except fish). This breaks inheriting the working directory for new tabs / windows with paths with special characters.
Example with zsh:
cd /Path/With/Special/Char??
kitty-shell-cwd://host.name/Path/With/Special/Char??
ghostty/src/shell-integration/zsh/ghostty-integration
Line 189 in ddf7173
kitty-shell-cwd://host.name/Path/With/Special/Char
ghostty/src/termio/stream_handler.zig
Line 1088 in ddf7173
/
in new tabI could provide a PR for zsh and probably bash, but I'm not 100% sure that encoding here is the right solution, or if it should be handled differently in
stream_handler.zig
. Especially since bash and zsh don't provide any url encoding builtins afaik. What do you think?Beta Was this translation helpful? Give feedback.
All reactions