Default config reload shortcut does not work

[slovdahl]

When I press ctrl+shift+, on my Swedish laptop QWERTY keyboard I just get ;5u written to the currently active terminal tab (see the screenshot), and info(io_handler): BELL is logged. The configuration is not reloaded (no "Reloaded the configuration" toast). Reloading the configuration from the hamburger menu works fine.

A Swedish keyboard has , and ; on the same physical key, with , being the default and shift+, gives ;. Is it somehow related to that? Other ctrl+shift keybinds like ctrl+shift+c and ctrl+shift+v work fine though.

I'm using Ubuntu 24.04 and GNOME 46 on Wayland.

Current config:

theme = Builtin Tango Dark
font-feature = -calt
font-feature = -liga
font-feature = -dlig
scrollback-limit = 50000000
clipboard-paste-protection = true
window-width = 160
window-height = 38
font-size = 10
mouse-scroll-multiplier = 0.5

This manual keybind works:

keybind = super+comma=reload_config

[slovdahl]

The same issue but for Spanish keyboards is reported in #3474.

[mitchellh]

I can reproduce this but as far as I can tell this is expected behavior. ctrl+shift+, doesn't seem like a possible keyboard behavior on Swedish QWERTY. Note the limitations similarly documented by Qt: https://doc.qt.io/qt-5/qkeysequence.html#keyboard-layout-issues (we don't use Qt but it's the same issue described).

Note on top of that, that macOS when setting ctrl+shift+, as a keyboard accelerator does not allow it to trigger with a Swedish keyboard layout. This doesn't hit the Ghostty system at all, this is purely through the macOS keyboard accelerator system for NSMenu. Similarly, ctrl+; triggers fine. Same issue.

Ghostty is seeing your input as ctrl+;. You can remap this using: ctrl+shift+physical:comma and it would work. This is what the physical binding is for.

As Qt notes, it is impossible for some set of bindings to work for every possible keyboard layout.

One thing I do notice is that outside of keyboard shortcuts, the legacy key encoding seems a bit wonky with Ghostty related to this. When pressing ctrl+shift+comma with legacy encoding I get the following:

• Terminal.app: Nothing (literally no bytes sent, I get a bell)
• iTerm2, Kitty, WezTerm, Alacritty: ,
• Ghostty: CSI u

Terminal.app isn't a great comparison because it's broken for all sorts of reasons. I'd be happy to follow the others but I'm unclear exactly what rules are being followed to result in the unshifted codepoint being emitted for the legacy encoding under this scenario.

Kitty keyboard encoding in Ghostty vs Kitty appears to work fine for this keypress, we report ctrl+shift+comma and ; as the shifted alternate.

[slovdahl]

Interesting, thanks. Curiously enough I have never ever seen or had a similar problem elsewhere. Reading the Qt docs makes me wonder how it hasn't happened in other programs. Just a happy coincidence? Maybe ctrl+shift plus a non-letter key isn't that common for this exact reason 🤔

[mitchellh]

Indeed, its one of the reasons the "command" key on macOS is very nice. ctrl+shift seems to be fairly standard on Linux but I'm open to other ideas if you have any, otherwise for now I suggest rebinding.

[mitchellh]

I'm going to mark this thread as the answer. If that turns out to be false please let me know.

[rhoot]

Ctrl+Shift+, isn't an impossible combination on a Swedish layout any more than it is on any other layout. Even the US layout has the same problem: Ctrl+Shift+, would effectively be Ctrl+<. But somehow this works with a US layout.

The Qt documentation refers to another (potential but not applicable) problem: Keys that require using another modifier in another layout. For example, a backtick requires shift on a Swedish layout, so Shift+` works with a US layout, but on a Swedish layout it would require Shift+Shift+´ (and thus be impossible).