Tabs leak memory when closed GTK

[rhodes-b]

This is easy to reproduce, open quite a few tabs (I did 20 new ones in this case) and see that memory is not being recovered when they are closed

@00-kat confirmed this in discord

These were my stats

202MB with one tab
275MB 20 tabs
close 20 tabs
235MB with one tab

It may be MiB im not sure what btop uses by default

[tristan957]

I can confirm the same leak. I tried to play with the address sanitizer, but nothing stood out as obvious. I also couldn't get the sanitizer to dump anything when a tab was closed, only when the window was closed. Maybe others will have better luck.

[rhodes-b]

Kat said she had attempted valgrind but it took like 10 mins of nothing happening before it just crashed, as a warning to others who may attempt that.

Gdb does work very well in my experience if someone really wants to try and go pretty deep

[iceghost]

my val grinded and this is the log:

==30067== 63,262,368 bytes in 19 blocks are possibly lost in loss record 20,887 of 20,887
==30067==    at 0x58DE866: malloc (vg_replace_malloc.c:446)
==30067==    by 0x6537CB9: g_malloc (in /usr/lib64/libglib-2.0.so.0.8200.2)
==30067==    by 0x5D0F5BF: ??? (in /usr/lib64/libgtk-4.so.1.1600.5)
==30067==    by 0x5D00967: gdk_gl_texture_release (in /usr/lib64/libgtk-4.so.1.1600.5)
==30067==    by 0x59D1BAC: ??? (in /usr/lib64/libgtk-4.so.1.1600.5)
==30067==    by 0x6528A8F: g_list_foreach (in /usr/lib64/libglib-2.0.so.0.8200.2)
==30067==    by 0x652DF46: g_list_free_full (in /usr/lib64/libglib-2.0.so.0.8200.2)
==30067==    by 0x59D21D3: ??? (in /usr/lib64/libgtk-4.so.1.1600.5)
==30067==    by 0x649873B: g_closure_invoke (in /usr/lib64/libgobject-2.0.so.0.8200.2)
==30067==    by 0x64C8ECF: ??? (in /usr/lib64/libgobject-2.0.so.0.8200.2)
==30067==    by 0x64B93E8: ??? (in /usr/lib64/libgobject-2.0.so.0.8200.2)
==30067==    by 0x64B9670: g_signal_emit_valist (in /usr/lib64/libgobject-2.0.so.0.8200.2)

(debuginfod didn't work with my valgrind for some reason)

[iceghost]

Full stack trace from breakpoint at gdk_gl_texture_release:

* frame #0: 0x00007ffff77ed8f0 libgtk-4.so.1`gdk_gl_texture_release
    frame #1: 0x00007ffff74bebad libgtk-4.so.1`___lldb_unnamed_symbol12509 + 45
    frame #2: 0x00007ffff7288a90 libglib-2.0.so.0`g_list_foreach + 48
    frame #3: 0x00007ffff728df47 libglib-2.0.so.0`g_list_free_full + 23
    frame #4: 0x00007ffff74bf1d4 libgtk-4.so.1`___lldb_unnamed_symbol12513 + 212
    frame #5: 0x00007ffff73a773c libgobject-2.0.so.0`g_closure_invoke + 172
    frame #6: 0x00007ffff73d7ed0 libgobject-2.0.so.0`___lldb_unnamed_symbol1335 + 3664
    frame #7: 0x00007ffff73c83e9 libgobject-2.0.so.0`___lldb_unnamed_symbol1168 + 4489
    frame #8: 0x00007ffff73c8671 libgobject-2.0.so.0`g_signal_emit_valist + 65
    frame #9: 0x00007ffff73c8733 libgobject-2.0.so.0`g_signal_emit + 147
    frame #10: 0x00007ffff75e8eb7 libgtk-4.so.1`gtk_widget_unrealize + 103
    frame #11: 0x00007ffff75f1c25 libgtk-4.so.1`___lldb_unnamed_symbol15526 + 117
    frame #12: 0x00007ffff73c7634 libgobject-2.0.so.0`___lldb_unnamed_symbol1168 + 980
    frame #13: 0x00007ffff73c8671 libgobject-2.0.so.0`g_signal_emit_valist + 65
    frame #14: 0x00007ffff73c8733 libgobject-2.0.so.0`g_signal_emit + 147
    frame #15: 0x00007ffff75e8eb7 libgtk-4.so.1`gtk_widget_unrealize + 103
    frame #16: 0x00007ffff75f1c25 libgtk-4.so.1`___lldb_unnamed_symbol15526 + 117
    frame #17: 0x00007ffff73c7634 libgobject-2.0.so.0`___lldb_unnamed_symbol1168 + 980
    frame #18: 0x00007ffff73c8671 libgobject-2.0.so.0`g_signal_emit_valist + 65
    frame #19: 0x00007ffff73c8733 libgobject-2.0.so.0`g_signal_emit + 147
    frame #20: 0x00007ffff75e8eb7 libgtk-4.so.1`gtk_widget_unrealize + 103
    frame #21: 0x00007ffff75f1c25 libgtk-4.so.1`___lldb_unnamed_symbol15526 + 117
    frame #22: 0x00007ffff73c855c libgobject-2.0.so.0`___lldb_unnamed_symbol1168 + 4860
    frame #23: 0x00007ffff73c8671 libgobject-2.0.so.0`g_signal_emit_valist + 65
    frame #24: 0x00007ffff73c8733 libgobject-2.0.so.0`g_signal_emit + 147
    frame #25: 0x00007ffff75e8eb7 libgtk-4.so.1`gtk_widget_unrealize + 103
    frame #26: 0x00007ffff75eb648 libgtk-4.so.1`gtk_widget_unparent + 776
    frame #27: 0x00007ffff70e6d72 libadwaita-1.so.0`___lldb_unnamed_symbol5380 + 194
    frame #28: 0x00007ffff70eaf8b libadwaita-1.so.0`___lldb_unnamed_symbol5395 + 43
    frame #29: 0x00007ffff7073350 libadwaita-1.so.0`___lldb_unnamed_symbol4191 + 64
    frame #30: 0x00007ffff73a77da libgobject-2.0.so.0`g_closure_invoke + 330
    frame #31: 0x00007ffff73d7ed0 libgobject-2.0.so.0`___lldb_unnamed_symbol1335 + 3664
    frame #32: 0x00007ffff73c7bf4 libgobject-2.0.so.0`___lldb_unnamed_symbol1168 + 2452
    frame #33: 0x00007ffff73c8671 libgobject-2.0.so.0`g_signal_emit_valist + 65
    frame #34: 0x00007ffff73c8733 libgobject-2.0.so.0`g_signal_emit + 147
    frame #35: 0x00007ffff70e7da5 libadwaita-1.so.0`adw_tab_view_close_page + 341
    frame #36: 0x0000000003479251 ghostty`apprt.gtk.notebook_adw.NotebookAdw.closeTab(self=0x00007ffff7fa8030, tab=0x00007fffe41ab000) at notebook_adw.zig:116:34
    frame #37: 0x0000000003431587 ghostty`apprt.gtk.notebook.Notebook.closeTab(self=0x00007ffff7fa8030, tab=0x00007fffe41ab000) at notebook.zig:157:40
    frame #38: 0x00000000033d886e ghostty`apprt.gtk.Window.closeTab(self=0x00007ffff7fa8000, tab=0x00007fffe41ab000) at Window.zig:444:27
    frame #39: 0x0000000003345dcc ghostty`apprt.gtk.Tab.remove(self=0x00007fffe41ab000) at Tab.zig:121:25
    frame #40: 0x0000000003250574 ghostty`apprt.gtk.Surface.Container.remove(self=apprt.gtk.Surface.Container @ 0x00007fffe41aa220) at Surface.zig:208:34
    frame #41: 0x00000000031ccafb ghostty`apprt.gtk.Surface.close(self=0x00007fffe419b000, processActive=false) at Surface.zig:705:30
    frame #42: 0x00000000031cae05 ghostty`Surface.close(self=0x00007fffe419b000) at Surface.zig:729:26
    frame #43: 0x00000000031ca47f ghostty`Surface.handleMessage(self=0x00007fffe419b000, msg=apprt.surface.Message @ 0x00007fffffffc6c0) at Surface.zig:921:23
    frame #44: 0x00000000031cbdb6 ghostty`App.surfaceMessage(self=0x00007ffff7fb3000, surface=0x00007fffe419b000, msg=apprt.surface.Message @ 0x00007fffffffc6c0) at App.zig:486:34
    frame #45: 0x00000000031cc0b6 ghostty`App.drainMailbox(self=0x00007ffff7fb3000, rt_app=0x00007fffffffcbd0) at App.zig:265:62
    frame #46: 0x00000000031cc7f7 ghostty`App.tick(self=0x00007ffff7fb3000, rt_app=0x00007fffffffcbd0) at App.zig:144:26
    frame #47: 0x00000000031ccf10 ghostty`apprt.gtk.App.run(self=0x00007fffffffcbd0) at App.zig:1177:51
    frame #48: 0x00000000031ce555 ghostty`main_ghostty.main at main_ghostty.zig:112:24
    frame #49: 0x00000000031cf05f ghostty`start.main [inlined] start.callMain at start.zig:524:37
    frame #50: 0x00000000031cf056 ghostty`start.main [inlined] start.callMainWithArgs at start.zig:482:20
    frame #51: 0x00000000031ceff9 ghostty`start.main(c_argc=1, c_argv=0x00007fffffffe338, c_envp=0x00007fffffffe348) at start.zig:497:75
    frame #52: 0x00007ffff6c46248 libc.so.6`__libc_start_call_main + 120
    frame #53: 0x00007ffff6c4630b libc.so.6`__libc_start_main@@GLIBC_2.34 + 139
    frame #54: 0x0000000002c888c5 ghostty`_start + 37

[mitchellh]

#5491