ci: upload dsym files as part of release builds

ghostty-org · Aug 29, 2024 · f41cefb · f41cefb
1 parent e24b767
commit f41cefb
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 9 deletions.
diff --git a/.github/workflows/release-pr.yml b/.github/workflows/release-pr.yml
@@ -42,6 +42,7 @@ jobs:
         run: |
           echo "GHOSTTY_BUILD=$(git rev-list --count head)" >> $GITHUB_ENV
           echo "GHOSTTY_COMMIT=$(git rev-parse --short HEAD)" >> $GITHUB_ENV
+          echo "GHOSTTY_COMMIT_LONG=$(git rev-parse HEAD)" >> $GITHUB_ENV
 
       # GhosttyKit is the framework that is built from Zig for our native
       # Mac app to access. Build this in release mode.
@@ -132,14 +133,18 @@ jobs:
 
       # Zip up the app
       - name: Zip App
-        run: cd macos/build/Release && zip -9 -r --symlinks ../../../ghostty-macos-universal.zip Ghostty.app
+        run: |
+          cd macos/build/Release
+          zip -9 -r --symlinks ../../../ghostty-macos-universal.zip Ghostty.app
+          zip -9 -r --symlinks ../../../ghostty-macos-universal-dsym.zip Ghostty.app.dSYM/
 
       # Update Blob Storage
       - name: Prep R2 Storage
         run: |
           mkdir blob
-          mkdir -p blob/${GHOSTTY_BUILD}
-          cp ghostty-macos-universal.zip blob/${GHOSTTY_BUILD}/ghostty-macos-universal.zip
+          mkdir -p blob/${GHOSTTY_COMMIT_LONG}
+          cp ghostty-macos-universal.zip blob/${GHOSTTY_COMMIT_LONG}/ghostty-macos-universal.zip
+          cp ghostty-macos-universal-dsym.zip blob/${GHOSTTY_COMMIT_LONG}/ghostty-macos-universal-dsym.zip
       - name: Upload to R2
         uses: ryand56/r2-upload-action@latest
         with:
@@ -185,6 +190,7 @@ jobs:
         run: |
           echo "GHOSTTY_BUILD=$(git rev-list --count head)" >> $GITHUB_ENV
           echo "GHOSTTY_COMMIT=$(git rev-parse --short HEAD)" >> $GITHUB_ENV
+          echo "GHOSTTY_COMMIT_LONG=$(git rev-parse HEAD)" >> $GITHUB_ENV
 
       # GhosttyKit is the framework that is built from Zig for our native
       # Mac app to access. Build this in release mode.
@@ -275,14 +281,18 @@ jobs:
 
       # Zip up the app
       - name: Zip App
-        run: cd macos/build/Release && zip -9 -r --symlinks ../../../ghostty-macos-universal-debug.zip Ghostty.app
+        run: |
+          cd macos/build/Release
+          zip -9 -r --symlinks ../../../ghostty-macos-universal-debug.zip Ghostty.app
+          zip -9 -r --symlinks ../../../ghostty-macos-universal-debug-dsym.zip Ghostty.app.dSYM/
 
       # Update Blob Storage
       - name: Prep R2 Storage
         run: |
           mkdir blob
-          mkdir -p blob/${GHOSTTY_BUILD}
-          cp ghostty-macos-universal-debug.zip blob/${GHOSTTY_BUILD}/ghostty-macos-universal-debug.zip
+          mkdir -p blob/${GHOSTTY_COMMIT_LONG}
+          cp ghostty-macos-universal-debug.zip blob/${GHOSTTY_COMMIT_LONG}/ghostty-macos-universal-debug.zip
+          cp ghostty-macos-universal-debug-dsym.zip blob/${GHOSTTY_COMMIT_LONG}/ghostty-macos-universal-debug-dsym.zip
       - name: Upload to R2
         uses: ryand56/r2-upload-action@latest
         with:

diff --git a/.github/workflows/release-tip.yml b/.github/workflows/release-tip.yml
@@ -155,9 +155,12 @@ jobs:
           echo "Attach staple"
           xcrun stapler staple "macos/build/Release/Ghostty.app"
 
-      # Zip up the app
+      # Zip up the app and symbols
       - name: Zip App
-        run: cd macos/build/Release && zip -9 -r --symlinks ../../../ghostty-macos-universal.zip Ghostty.app
+        run: |
+          cd macos/build/Release
+          zip -9 -r --symlinks ../../../ghostty-macos-universal.zip Ghostty.app
+          zip -9 -r --symlinks ../../../ghostty-macos-universal-dsym.zip Ghostty.app.dSYM/
 
       # Update Release
       - name: Release
@@ -187,6 +190,7 @@ jobs:
           mkdir blob
           mkdir -p blob/${GHOSTTY_COMMIT_LONG}
           cp ghostty-macos-universal.zip blob/${GHOSTTY_COMMIT_LONG}/ghostty-macos-universal.zip
+          cp ghostty-macos-universal-dsym.zip blob/${GHOSTTY_COMMIT_LONG}/ghostty-macos-universal-dsym.zip
           cp appcast_new.xml blob/appcast.xml
       - name: Upload to R2
         uses: ryand56/r2-upload-action@latest
@@ -334,7 +338,10 @@ jobs:
 
       # Zip up the app
       - name: Zip App
-        run: cd macos/build/Release && zip -9 -r --symlinks ../../../ghostty-macos-universal-debug.zip Ghostty.app
+        run: |
+          cd macos/build/Release
+          zip -9 -r --symlinks ../../../ghostty-macos-universal-debug.zip Ghostty.app
+          zip -9 -r --symlinks ../../../ghostty-macos-universal-debug-dsym.zip Ghostty.app.dSYM/
 
       # Update Release
       - name: Release
@@ -353,6 +360,7 @@ jobs:
           mkdir blob
           mkdir -p blob/${GHOSTTY_COMMIT_LONG}
           cp ghostty-macos-universal-debug.zip blob/${GHOSTTY_COMMIT_LONG}/ghostty-macos-universal-debug.zip
+          cp ghostty-macos-universal-dsym.zip blob/${GHOSTTY_COMMIT_LONG}/ghostty-macos-universal-dsym.zip
       - name: Upload to R2
         uses: ryand56/r2-upload-action@latest
         with:

diff --git a/macos/Ghostty.xcodeproj/project.pbxproj b/macos/Ghostty.xcodeproj/project.pbxproj
@@ -770,6 +770,7 @@
 				CODE_SIGN_STYLE = Automatic;
 				COMBINE_HIDPI_IMAGES = YES;
 				CURRENT_PROJECT_VERSION = 1;
+				DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
 				DEVELOPMENT_TEAM = "";
 				ENABLE_HARDENED_RUNTIME = YES;
 				ENABLE_PREVIEWS = YES;