From 78790f6ef75c95929ad8dcb56b79efe91be55c64 Mon Sep 17 00:00:00 2001 From: Qwerasd Date: Thu, 23 Jan 2025 20:06:53 -0500 Subject: [PATCH] fix(Metal): always render explicit background colors fully opaque This fixes a regression introduced by the rework of this area before during the color space changes. It seems like the original intent of this code was the behavior it regressed to, but it turns out to be better like this. --- src/renderer/Metal.zig | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/renderer/Metal.zig b/src/renderer/Metal.zig index bf28b58ac4..52a5437c66 100644 --- a/src/renderer/Metal.zig +++ b/src/renderer/Metal.zig @@ -2672,9 +2672,8 @@ fn rebuildCells( // Cells that are reversed should be fully opaque. if (style.flags.inverse) break :bg_alpha default; - // Cells that have an explicit bg color, which does not - // match the current surface bg, should be fully opaque. - if (bg != null and !rgb.eql(self.background_color orelse self.default_background_color)) { + // Cells that have an explicit bg color should be fully opaque. + if (bg_style != null) { break :bg_alpha default; }