Merge pull request #2 from penhorwood/master

Payflow unit test from @penhorwood to confirm gateway works as expected for issue #1.
ghidinelli · Jun 25, 2013 · ba863ef · ba863ef
2 parents 64cdf45 + 69de587
commit ba863ef
Show file tree

Hide file tree

Showing 2 changed files with 599 additions and 3 deletions.
diff --git a/api/gateway/paypal/payflow/payflowGateway.cfc b/api/gateway/paypal/payflow/payflowGateway.cfc
@@ -155,7 +155,7 @@
 				access     = "public"
 				returntype = "any"
 				output     = "false"
-				purpose    = ""
+				purpose    = "Inquiry Transaction by TransactionID. Other types of inquiry transactions are not supported."
 				author     = "Andrew Penhorwood"
 				created    = "08/30/2012">
 
@@ -641,14 +641,14 @@
 
 				<cfif structKeyExists(arguments.payload, "TRXTYPE")>
 					<!--- authorize (Authorization Transaction) & purchase (Sale Transaction) --->
-					<cfif arguments.payload.TRXTYPE EQ "A,S">
+					<cfif inList("A,S", arguments.payload.TRXTYPE)>
 						<cfif structKeyExists(results, "PNREF")>
 							<cfset response.setTransactionId(results.PNREF)>
 							<cfset response.setAuthorization(results.PNREF)>
 						</cfif>
 
 					<!--- capture (Delayed Capture Transaction) --->
-					<cfelseif arguments.payload.TRXTYPE EQ "D,C,I,V">
+					<cfelseif inList("D,C,I,V", arguments.payload.TRXTYPE)>
 						<cfif structKeyExists(results, "PNREF")>
 							<cfset response.setTransactionId(results.PNREF)>
 						</cfif>