-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: feat: only require depth config. for fmts. w/ depth #6026
Draft
ErichDonGubler
wants to merge
1
commit into
gfx-rs:trunk
Choose a base branch
from
erichdongubler-mozilla:require-depth-deets-only-for-depthy-fmts
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP: feat: only require depth config. for fmts. w/ depth #6026
ErichDonGubler
wants to merge
1
commit into
gfx-rs:trunk
from
erichdongubler-mozilla:require-depth-deets-only-for-depthy-fmts
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jul 24, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
Corresponding Bugzilla link for Firefox: bug 1910140 |
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Aug 22, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Sep 6, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Sep 6, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Sep 13, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Sep 13, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Sep 15, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Sep 17, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Sep 18, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Sep 23, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Sep 26, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Sep 28, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Oct 10, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
a5b3d3a
to
334c0a0
Compare
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Oct 16, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Oct 21, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Oct 30, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
9a5e366
to
ca1b8b9
Compare
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Nov 1, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ca1b8b9
to
d7e9da9
Compare
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Nov 4, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Nov 5, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Nov 7, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
2b4f880
to
9ae0fda
Compare
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Dec 19, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/gecko-dev
that referenced
this pull request
Dec 28, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Dec 28, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/gecko-dev
that referenced
this pull request
Dec 31, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/gecko-dev
that referenced
this pull request
Jan 7, 2025
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/gecko-dev
that referenced
this pull request
Jan 9, 2025
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/gecko-dev
that referenced
this pull request
Jan 10, 2025
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
9ae0fda
to
494b31d
Compare
ErichDonGubler
added a commit
to erichdongubler-mozilla/gecko-dev
that referenced
this pull request
Jan 14, 2025
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/gecko-dev
that referenced
this pull request
Jan 15, 2025
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/gecko-dev
that referenced
this pull request
Jan 16, 2025
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/gecko-dev
that referenced
this pull request
Jan 17, 2025
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/gecko-dev
that referenced
this pull request
Jan 22, 2025
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/gecko-dev
that referenced
this pull request
Jan 24, 2025
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/gecko-dev
that referenced
this pull request
Jan 28, 2025
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
494b31d
to
dfe62f1
Compare
ErichDonGubler
added a commit
to erichdongubler-mozilla/gecko-dev
that referenced
this pull request
Feb 4, 2025
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/gecko-dev
that referenced
this pull request
Feb 4, 2025
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/gecko-dev
that referenced
this pull request
Feb 13, 2025
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/gecko-dev
that referenced
this pull request
Feb 14, 2025
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/gecko-dev
that referenced
this pull request
Feb 15, 2025
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
dfe62f1
to
9bed532
Compare
ErichDonGubler
added a commit
to erichdongubler-mozilla/gecko-dev
that referenced
this pull request
Feb 16, 2025
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/gecko-dev
that referenced
this pull request
Feb 19, 2025
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/gecko-dev
that referenced
this pull request
Feb 21, 2025
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/gecko-dev
that referenced
this pull request
Feb 24, 2025
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
TODO: Ensure that the following changes and discussion get represented in code: - https://github.com/gpuweb/gpuweb/pull/4318/files - gpuweb/gpuweb#3905 - https://github.com/gpuweb/gpuweb/pull/3849/files#r1122411287
9bed532
to
953f7c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Ensure that the following changes and discussion get represented in code:
Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Description
Describe what problem this is solving, and how it's solved.
Testing
Explain how this change is tested.
Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.