-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement wgpuComputePassEncoderSetPushConstants
#437
Conversation
Let's keep the |
cc @fyellin since you implemented render push constants in wgpu-py. |
2befee3
to
52537a2
Compare
52537a2
to
9ef09a0
Compare
rebased and added examples/push_constants Also noting that I used my fork of wgpu with these PRs in a project and they all worked as expected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far! Added couple of comments.
We could also consider porting over this wgpu test so that we have a reference to track any future wgpu-core API changes and easily update the examples if needed.
Apart from the example, the API changes LGTM (and tests correctly with current example code). If you need we could merge the API changes in this PR, and do the example in a separate PR. |
b963b58
to
fd4a138
Compare
fd4a138
to
9f21540
Compare
When will this code be available to use in wgpu-py? |
@fyellin when a new version of wgpu-native is released, and wgpu-py updates to that release. |
pls merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Looks good!
(I also added a commit to run the example in CI)
Thanks @zackgomez ! |
It was straightforward to implement. I don't expect my changes to the example to be merged, I am looking for guidance on whether they should be reverted, moved to another example, or something else entirely.
Test Plan:
Modified the compute shader to use push constants. Verified the output.