Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: setup cache #308

Merged
merged 2 commits into from
Oct 29, 2023
Merged

ci: setup cache #308

merged 2 commits into from
Oct 29, 2023

Conversation

rajveermalviya
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@almarklein almarklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some formatting so its a bit hard what code actually changed, but I think you only added these blocks, right?

- name: Setup caching
        uses: Swatinem/rust-cache@v2
        with:
          key: build-${{ env.TARGET }}-${{ env.CACHE_SUFFIX }}

And IIUC they cache (versioned) Rust dependencies, so the builds are faster.

@rajveermalviya
Copy link
Collaborator Author

Yeah, formatting is done via the Prettier extension from vscode. So thought I had to include it too, to make the review easier I separated them in 2 different commits.

Thanks to this caching, it reduces the workflow times significantly: after caching, before caching

@almarklein
Copy link
Collaborator

to make the review easier I separated them in 2 different commits.

Ah! Nice thinking, I missed that initially, but very clear indeed 👍

Nice speedup!

@almarklein almarklein merged commit a5dee28 into gfx-rs:trunk Oct 29, 2023
@rajveermalviya rajveermalviya deleted the workflow-cache branch October 29, 2023 20:45
prime31 added a commit to prime31/wgpu-native that referenced this pull request Oct 31, 2023
commit a5dee28
Author: Rajesh Malviya <rajveer0malviya@gmail.com>
Date:   Mon Oct 30 02:11:56 2023 +0530

    ci: setup cache (gfx-rs#308)

    * fmt

    * setup caching

commit 168846f
Author: Rajesh Malviya <rajveer0malviya@gmail.com>
Date:   Sat Oct 28 01:30:27 2023 +0530

    update wgpu to 0.18.0 (gfx-rs#307)

commit c373595
Author: Rajesh Malviya <rajveer0malviya@gmail.com>
Date:   Tue Oct 24 20:46:48 2023 +0000

    update wgpu to current trunk (gfx-rs#306)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants