Fix an issue where PNG images cannot be loaded on Ubuntu #470
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The latest CI failed because SATySFi failed to load PNG images on Ubuntu.
https://github.com/gfngfn/SATySFi/actions/runs/12861909507/job/35855999813
SATySFi manually built on Ubuntu failed to load PNG too.
Cause
It is because
camlimages
, which provides functionalities to load PNG images, was built withoutlibpng
.As
conf-libpng
is optional forcamlimages
,libpng
(technically,libpng-dev
apt package on Ubuntu) is not installed byopam install . --deps-only
in CI.https://gitlab.com/camlspotter/camlimages/-/blob/83c53c196fc1e7766ed5c636c3f1d2418ce41293/dune-project#L27-38
Solution
Add
conf-libpng
topackage.depends
ofdune-project
.P.S. I am completely new to OCaml and its ecosystem and am not sure about the correctness of the changes.