Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apidocs): fix typo in user feedback api #85280

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

michellewzhang
Copy link
Member

rm the extra asterisk

SCR-20250214-luqo

after
SCR-20250214-luoz

@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Feb 14, 2025
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@michellewzhang michellewzhang marked this pull request as ready for review February 14, 2025 21:12
@michellewzhang michellewzhang requested review from a team as code owners February 14, 2025 21:12
@michellewzhang michellewzhang requested a review from a team February 14, 2025 21:12
@@ -47,7 +47,7 @@ def get(self, request: Request, project) -> Response:

Return a list of user feedback items within this project.

*This list does not include submissions from the [User Feedback Widget](https://docs.sentry.io/product/user-feedback/#user-feedback-widget). This is because it is based on an older format called User Reports - read more [here](https://develop.sentry.dev/application/feedback-architecture/#user-reports).*
*This list does not include submissions from the [User Feedback Widget](https://docs.sentry.io/product/user-feedback/#user-feedback-widget). This is because it is based on an older format called User Reports - read more [here](https://develop.sentry.dev/application/feedback-architecture/#user-reports). To return a list of user feedback items from the widget, please use the [issue API](https://docs.sentry.io/api/events/list-a-projects-issues/) with the filter `issue.category:feedback`.*
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't used to render the api docs (we're still using the old way above) but we should keep them in sync with each other if we ever convert to the new api schema format

Copy link
Member

@iamrajjoshi iamrajjoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we chatted offline - this endpoint will eventually be deprecated/removed and we will delete the docs, so not worth the effort to move this over to the new doc standards

@michellewzhang michellewzhang merged commit 33c0f2d into master Feb 14, 2025
49 of 50 checks passed
@michellewzhang michellewzhang deleted the mz/fix-asterisk-uf-doc branch February 14, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants