Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(post_process): Schedule less tasks to derive code mappings #83638

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

armenzg
Copy link
Member

@armenzg armenzg commented Jan 17, 2025

This adds two one-second locks to prevent scheduling many tasks that use locking internally.

This also makes some other minor changes.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 17, 2025
Base automatically changed from drop/pickled_data/derive_code_mappings/armenzg to master January 17, 2025 15:02
Copy link

codecov bot commented Jan 17, 2025

❌ 7 Tests Failed:

Tests completed Failed Passed Skipped
23574 7 23567 276
View the top 3 failed tests by shortest run time
tests.sentry.tasks.test_post_process.PostProcessGroupErrorTest::test_only_maps_a_given_issue_once_per_day
Stack Traces | 5.98s run time
#x1B[1m#x1B[.../sentry/tasks/test_post_process.py#x1B[0m:324: in test_only_maps_a_given_issue_once_per_day
    assert mock_derive_code_mappings.delay.call_count == 1
#x1B[1m#x1B[31mE   AssertionError: assert 0 == 1#x1B[0m
#x1B[1m#x1B[31mE    +  where 0 = <MagicMock name='derive_code_mappings.delay' id='140399592045408'>.call_count#x1B[0m
#x1B[1m#x1B[31mE    +    where <MagicMock name='derive_code_mappings.delay' id='140399592045408'> = <MagicMock name='derive_code_mappings' id='140399590118400'>.delay#x1B[0m
tests.sentry.api.endpoints.test_organization_events_trends_v2.OrganizationEventsTrendsStatsV2EndpointTest::test_two_projects_same_transaction_split_queries
Stack Traces | 5.99s run time
#x1B[1m#x1B[.../api/endpoints/test_organization_events_trends_v2.py#x1B[0m:414: in test_two_projects_same_transaction_split_queries
    assert len(trends_call_args_data_1[f"{project1.id},foo bar*"]) > 0
#x1B[1m#x1B[31mE   KeyError: '4555400802205700,foo bar*'#x1B[0m
tests.sentry.tasks.test_post_process.PostProcessGroupErrorTest::test_skipping_an_issue_doesnt_mark_it_processed
Stack Traces | 6.02s run time
#x1B[1m#x1B[.../sentry/tasks/test_post_process.py#x1B[0m:366: in test_skipping_an_issue_doesnt_mark_it_processed
    assert mock_derive_code_mappings.delay.call_count == 1
#x1B[1m#x1B[31mE   AssertionError: assert 0 == 1#x1B[0m
#x1B[1m#x1B[31mE    +  where 0 = <MagicMock name='derive_code_mappings.delay' id='140399386429152'>.call_count#x1B[0m
#x1B[1m#x1B[31mE    +    where <MagicMock name='derive_code_mappings.delay' id='140399386429152'> = <MagicMock name='derive_code_mappings' id='140399386439232'>.delay#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@armenzg armenzg force-pushed the feat/improve_scheduling/auto_source_code_config/armenzg branch from 323e05a to 77f8171 Compare January 17, 2025 15:53
This adds two one second locks to prevent scheduling a lot of tasks which use locking internally.

This also makes some other minor changes.
@armenzg armenzg force-pushed the feat/improve_scheduling/auto_source_code_config/armenzg branch from 77f8171 to 74abba2 Compare January 17, 2025 15:54
@getsantry
Copy link
Contributor

getsantry bot commented Feb 8, 2025

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant