feat(ui): Upgrade to react 18.3 #83334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrading to react 18.3 helps with the react 19 migration by displaying various warnings for features that are removed in react 19. https://react.dev/blog/2024/04/25/react-19-upgrade-guide part of getsentry/frontend-tsc#68
github-actions
bot
added
the
Scope: Frontend
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Bundle ReportChanges will increase total bundle size by 530 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: app-webpack-bundle-array-pushAssets Changed:
Files in
|
# Conflicts: # package.json # yarn.lock
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
# Conflicts: # package.json # yarn.lock
scttcper
commented
Feb 13, 2025
Comment on lines
+39
to
+42
| // TODO: Remove after either the removal of AsyncComponent or migrating the tests not to use contexts | ||
| if ( | ||
| /uses the legacy contextTypes API which is no longer supported/.test(errorMessage) | ||
| ) { |
There was a problem hiding this comment.
prevents one of the new warnings from failing tests for AsyncComponent
scttcper
commented
Feb 13, 2025
| /uses the legacy contextTypes API/, | ||
| // TODO(react19): Another error from AsyncComponent. | ||
| // <ComponentName> declares both contextTypes and contextType static properties. The legacy contextTypes property will be ignored. | ||
| /declares both contextTypes and contextType static properties/, |
There was a problem hiding this comment.
optional, but the warnings are annoying if you're working on an async component
evanpurkhiser
approved these changes
Feb 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://react.dev/blog/2024/04/25/react-19-upgrade-guide
part of https://github.com/getsentry/frontend-tsc/issues/68