IA-98: add rollout for sentry task latency #83244
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
bmckerry
commented
Jan 10, 2025
Comment on lines
-89
to
-90
| # Use a try/catch here to contain the blast radius of an exception being unhandled through the options lib | ||
| # Unhandled exception could cause all tasks to be effected and not work |
There was a problem hiding this comment.
the code this comment refers to was deleted in a previous PR
src/sentry/tasks/base.py
Outdated
| do_record_timing_rollout = False | ||
| record_timing_rollout = options.get("sentry.tasks.record.timing.rollout") | ||
| if record_timing_rollout and record_timing_rollout > random(): | ||
| do_record_timing_rollout = True |
There was a problem hiding this comment.
setting record_timing = True here made it so the wrapped function wouldn't use the parameter record_timing, so I added do_record_timing_rollout for the rollout logic
markstory
reviewed
Jan 10, 2025
src/sentry/tasks/base.py
Outdated
Comment on lines
90
to
91
| record_timing_rollout = options.get("sentry.tasks.record.timing.rollout") | ||
| if record_timing_rollout and record_timing_rollout > random(): |
There was a problem hiding this comment.
You could use sentry.features.rollout.in_random_rollout to handle the comparison with random and handling unset option values.
❌ 4 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #71778 the option to allow latency metrics from a
SentryTaskwas added, but defaulted to false and has since only been enabled on 3 tasks.This PR adds a rollout option to increase the rate at which all tasks in a region report latency metrics. This will allow us to configure monitors based off of task latency instead of backlog similar to what we have for kafka.