Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metrics-extraction): Allow cut over to stateful extraction #61838

Merged
merged 2 commits into from
Dec 15, 2023
Merged

feat(metrics-extraction): Allow cut over to stateful extraction #61838

merged 2 commits into from
Dec 15, 2023

Conversation

k-fish
Copy link
Member

@k-fish k-fish commented Dec 15, 2023 •
edited
Loading

This adds code to both measure and allow cutting over to stateful extraction once we confirm there are no problems between the two extraction states.

@k-fish
feat(metrics-extraction): Allow cut over to stateful extraction
74c6779 
This adds code to both measure and allow cutting over to stateful extraction once we confirm there are no problems between the two extraction states.
@k-fish k-fish self-assigned this Dec 15, 2023
@k-fish k-fish requested a review from a team as a code owner December 15, 2023 14:57
@k-fish k-fish requested a review from armenzg December 15, 2023 14:57
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 15, 2023
armenzg
armenzg approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@armenzg armenzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@codecov Codecov
Copy link

codecov bot commented Dec 15, 2023 •
edited
Loading

Codecov Report

Merging #61838 (53e6c20) into master (dca773f) will decrease coverage by 0.01%.
Report is 9 commits behind head on master.
The diff coverage is 56.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #61838      +/-   ##
==========================================
- Coverage   81.20%   81.19%   -0.01%     
==========================================
  Files        5187     5187              
  Lines      228378   228406      +28     
  Branches    38310    38315       +5     
==========================================
+ Hits       185443   185453      +10     
- Misses      37296    37310      +14     
- Partials     5639     5643       +4
Files Coverage Δ
src/sentry/options/defaults.py 100.00% <100.00%> (ø)
src/sentry/tasks/on_demand_metrics.py 92.94% <100.00%> (ø)
static/app/components/modals/widgetViewerModal.tsx 77.31% <ø> (ø)
src/sentry/relay/config/metric_extraction.py 81.88% <52.17%> (-3.00%) ⬇️

... and 8 files with indirect coverage changes

@k-fish k-fish merged commit 477f506 into master Dec 15, 2023
48 of 49 checks passed
@k-fish k-fish deleted the ref/metrics-extraction-add-metric-and-exception-cut-over branch December 15, 2023 17:12
@IanWoodard IanWoodard added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Dec 15, 2023
@getsentry-bot
Copy link
Contributor

PR reverted: 17b7a79

getsentry-bot added a commit that referenced this pull request Dec 15, 2023
@getsentry-bot @IanWoodard
Revert "feat(metrics-extraction): Allow cut over to stateful extracti…
17b7a79 
…on (#61838)"

This reverts commit 477f506.

Co-authored-by: IanWoodard <17186604+IanWoodard@users.noreply.github.com>
k-fish added a commit that referenced this pull request Dec 15, 2023
@k-fish
feat(metrics-extraction): Allow cut over to stateful extraction
7111670 
Unrevert #61838
@k-fish k-fish mentioned this pull request Dec 15, 2023
Merged
k-fish added a commit that referenced this pull request Dec 15, 2023
@k-fish
feat(metrics-extraction): Allow cut over to stateful extraction (#61860)
57d82a1 
Unrevert #61838

Fixes previous revert:
- Exclude error event widgets from extracting specs at all
@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armenzg armenzg armenzg approved these changes

Assignees

@k-fish k-fish

Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@k-fish @getsentry-bot @armenzg @IanWoodard