Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Julia/discord setup url #61584

Merged
merged 13 commits into from
Dec 13, 2023
Merged

Julia/discord setup url #61584

merged 13 commits into from
Dec 13, 2023

Conversation

17hogeju
Copy link
Contributor

Discord Integration flow fix

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 12, 2023
@17hogeju 17hogeju marked this pull request as ready for review December 12, 2023 21:51
@17hogeju 17hogeju requested a review from a team as a code owner December 12, 2023 21:51
@17hogeju 17hogeju requested a review from scefali December 12, 2023 21:51
@codecov Codecov
Copy link

codecov bot commented Dec 12, 2023 •
edited
Loading

Codecov Report

Merging #61584 (759e935) into master (8d5fc20) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 94.44%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #61584   +/-   ##
=======================================
  Coverage   81.14%   81.15%           
=======================================
  Files        5188     5188           
  Lines      228371   228384   +13     
  Branches    38290    38290           
=======================================
+ Hits       185323   185346   +23     
+ Misses      37423    37414    -9     
+ Partials     5625     5624    -1
Files Coverage Δ
src/sentry/integrations/discord/urls.py 100.00% <ø> (ø)
src/sentry/integrations/discord/integration.py 96.32% <94.44%> (-0.43%) ⬇️

... and 8 files with indirect coverage changes

@17hogeju 17hogeju requested a review from scefali December 13, 2023 18:49
@17hogeju 17hogeju merged commit 8c7d2f8 into master Dec 13, 2023
49 checks passed
@17hogeju 17hogeju deleted the julia/discord-setup-url branch December 13, 2023 21:06
@sentry-io Sentry.io
Copy link

sentry-io bot commented Dec 13, 2023 •
edited
Loading

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: 'QueryDict' object is not callable /extensions/discord/configure/ View Issue
  • ‼️ TypeError: 'QueryDict' object is not callable PipelineAdvancerView View Issue

Did you find this useful? React with a 👍 or 👎

@17hogeju 17hogeju added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Dec 14, 2023
@getsentry-bot
Copy link
Contributor

PR reverted: b2e4a96

getsentry-bot added a commit that referenced this pull request Dec 14, 2023
@getsentry-bot @17hogeju
Revert "Julia/discord setup url (#61584)"
b2e4a96 
This reverts commit 8c7d2f8.

Co-authored-by: 17hogeju <22582037+17hogeju@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scefali scefali scefali approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@17hogeju @getsentry-bot @scefali