ref(crons): Move save out of update_config

[evanpurkhiser]

It's probably better to be explicit here.

I would like to make some other changes to the monitor outside of just
updating the config in some places. So I don't want to call save twice.

[rjo100]

did you forget to remove the .save() from models.py?

[evanpurkhiser]

Good catch, missed it when staging

[codecov]

Codecov Report

Merging #58826 (73e30d0) into master (083bd82) will decrease coverage by 0.01%.
Report is 1912 commits behind head on master.
The diff coverage is 80.95%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #58826      +/-   ##
==========================================
- Coverage   80.62%   80.62%   -0.01%     
==========================================
  Files        5154     5154              
  Lines      225708   225736      +28     
  Branches    38029    38032       +3     
==========================================
+ Hits       181969   181991      +22     
- Misses      38184    38189       +5     
- Partials     5555     5556       +1     

Files	Coverage Δ
src/sentry/issues/json_schemas.py	100.00% <100.00%> (ø)
src/sentry/issues/occurrence_consumer.py	92.18% <100.00%> (+0.25%)	⬆️
...monitors/endpoints/monitor_ingest_checkin_index.py	94.56% <100.00%> (+0.05%)	⬆️
...c/sentry/sentry_metrics/consumers/indexer/batch.py	92.12% <100.00%> (-0.08%)	⬇️
.../sentry/sentry_metrics/consumers/indexer/common.py	88.00% <100.00%> (+0.12%)	⬆️
static/app/components/commitLink.tsx	35.71% <ø> (ø)
.../components/replays/breadcrumbs/replayTimeline.tsx	0.00% <ø> (ø)
...onents/replays/player/useScrubberMouseTracking.tsx	0.00% <ø> (ø)
static/app/components/resolutionBox.tsx	93.75% <ø> (ø)
...y/sentry_metrics/consumers/indexer/multiprocess.py	84.12% <60.00%> (-2.76%)	⬇️
... and 1 more

... and 5 files with indirect coverage changes

[getsantry]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[rjo100]

did you forget to remove the .save() from models.py?

bumping old comment

[getsantry]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀