Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update perfview #3492

Merged
merged 5 commits into from
Oct 2, 2024
Merged

deps: update perfview #3492

merged 5 commits into from
Oct 2, 2024

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Jul 16, 2024 •
edited
Loading

@vaind vaind marked this pull request as ready for review October 1, 2024 21:05
bitsandfoxes
bitsandfoxes approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's be amazing if that did the trick! 🔥

bruno-garcia
bruno-garcia approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally we add to changelog what we get with the bump. On the submodule bumps it links to diffs at least. ut here since it was manual we can just mention what we expect to improve

@bruno-garcia bruno-garcia merged commit b8849ac into main Oct 2, 2024
23 checks passed
@bruno-garcia bruno-garcia deleted the deps/perfview branch October 2, 2024 02:45
This was referenced Oct 2, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@bitsandfoxes bitsandfoxes bitsandfoxes approved these changes

@jamescrosswell jamescrosswell Awaiting requested review from jamescrosswell jamescrosswell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaind @bruno-garcia @bitsandfoxes