chore: dotnet format PRs
#3097
Merged
chore: dotnet format PRs
#3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
approved these changes
Jan 30, 2024
jamescrosswell
approved these changes
Jan 30, 2024
bitsandfoxes
commented
Jan 31, 2024
Comment on lines
18
to
19
| [RequiresDynamicCode("Calls Microsoft.Extensions.Configuration.ConfigurationBinder.Bind(Object)")] | ||
| [RequiresUnreferencedCode("Calls Microsoft.Extensions.Configuration.ConfigurationBinder.Bind(Object)")] |
There was a problem hiding this comment.
@jamescrosswell do you know by chance what's up with that?
There was a problem hiding this comment.
No idea. At first glance, the Check failure is nonsense.
There was a problem hiding this comment.
So we added the code it's complaining about in b84faa8... the whole purpose of which was to avoid Dynamic Code in the configuration binding.
The inclusion of Microsoft.Extensions.Configuration.Binder and setting <EnableConfigurationBindingGenerator>true</EnableConfigurationBindingGenerator> in the project file mean that call to Bind will be replaced by a source generated binder... so there isnt' any dynamic code.
If we add the two attributes above, it will break AOT Compatibility (unecessarily).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1503
Because I don't want to nitpick or talk about tabs vs spaces.
#skip-changelog